diff --git a/data-access/servlet/src/main/java/auth/oidc/InvalidTokenException.java b/data-access/BACKUP/auth/oidc/InvalidTokenException.java similarity index 100% rename from data-access/servlet/src/main/java/auth/oidc/InvalidTokenException.java rename to data-access/BACKUP/auth/oidc/InvalidTokenException.java diff --git a/data-access/servlet/src/main/java/auth/oidc/Ivoid.java b/data-access/BACKUP/auth/oidc/Ivoid.java similarity index 100% rename from data-access/servlet/src/main/java/auth/oidc/Ivoid.java rename to data-access/BACKUP/auth/oidc/Ivoid.java diff --git a/data-access/servlet/src/main/java/auth/oidc/VlkbUser.java b/data-access/BACKUP/auth/oidc/VlkbUser.java similarity index 100% rename from data-access/servlet/src/main/java/auth/oidc/VlkbUser.java rename to data-access/BACKUP/auth/oidc/VlkbUser.java diff --git a/data-access/servlet/src/main/java/auth/authz/AuthPolicy.java b/data-access/servlet/src/main/java/auth/authz/AuthPolicy.java index 1c5efc13c36da3e58c87f610f4e2d7061b916691..cd5dfd0ec574c4b811394801176e0f39ecf3a407 100644 --- a/data-access/servlet/src/main/java/auth/authz/AuthPolicy.java +++ b/data-access/servlet/src/main/java/auth/authz/AuthPolicy.java @@ -40,9 +40,9 @@ public class AuthPolicy private String[] userGroups; private boolean userGroupsValid; - private String dbConnUrl; - private String dbUserName; - private String dbPassword; +// private String dbConnUrl; +// private String dbUserName; +// private String dbPassword; public AuthPolicy(String userName, String[] userGroups) @@ -158,27 +158,27 @@ public class AuthPolicy - public String[] filterAuthorized(String[] pubdidArr, String dbConnUrl, String dbUserName, String dbPassword) + public String[] filterAuthorized(String[] pubdidArr) { //this.dbConnUrl = dbConnUrl; - this.dbUserName = dbUserName; - this.dbPassword = dbPassword; + //this.dbUserName = dbUserName; + //this.dbPassword = dbPassword; LOGGER.finer("with String[] trace"); - return filterAuthorized(new ArrayList<String>(Arrays.asList(pubdidArr)), dbConnUrl); + return filterAuthorized(new ArrayList<String>(Arrays.asList(pubdidArr))); } - private String[] filterAuthorized(ArrayList<String> pubdidList, String dbConnUrl) + private String[] filterAuthorized(ArrayList<String> pubdidList) { LOGGER.fine("with List <String> trace"); switch(access) { case PUBLIC_ONLY : - filterNotPublic(pubdidList, dbConnUrl); + filterNotPublic(pubdidList); break; case PUBLIC_AND_AUTHORIZED_PRIVATE : - filterNotAuthorized(pubdidList, dbConnUrl); + filterNotAuthorized(pubdidList); break; default : @@ -188,13 +188,13 @@ public class AuthPolicy } - private void filterNotPublic(ArrayList<String> pubdids, String dbConnUrl) + private void filterNotPublic(ArrayList<String> pubdids) { LOGGER.fine("trace"); assert pubdids != null; LOGGER.finer("PublisherDID list original : " + String.join(" ", pubdids)); - List<AuthPolicyDb.PubdidGroups> privateUniqPubdids = db_queryPrivateUniqPubdidGroups(dbConnUrl, pubdids); + List<AuthPolicyDb.PubdidGroups> privateUniqPubdids = db_queryPrivateUniqPubdidGroups(pubdids); List<String> notAuthorizedUniqPubdids = pubdidsNotPublic(privateUniqPubdids, userGroups); LOGGER.finest("AuthZ removes: " + String.join(" ", notAuthorizedUniqPubdids)); @@ -230,13 +230,13 @@ public class AuthPolicy - private void filterNotAuthorized(ArrayList<String> pubdids, String dbConnUrl) + private void filterNotAuthorized(ArrayList<String> pubdids) { LOGGER.fine("trace"); assert pubdids != null; LOGGER.finer("PublisherDID list original : " + String.join(" ", pubdids)); - List<AuthPolicyDb.PubdidGroups> privateUniqPubdids = db_queryPrivateUniqPubdidGroups(dbConnUrl, pubdids); + List<AuthPolicyDb.PubdidGroups> privateUniqPubdids = db_queryPrivateUniqPubdidGroups(pubdids); List<String> notAuthorizedUniqPubdids = pubdidsNotAuthorized(privateUniqPubdids, userGroups); LOGGER.finest("AuthZ removes: " + String.join(" ", notAuthorizedUniqPubdids)); @@ -266,14 +266,14 @@ public class AuthPolicy - private List<AuthPolicyDb.PubdidGroups> db_queryPrivateUniqPubdidGroups(String dbConnUrl, List<String> pubdids) + private List<AuthPolicyDb.PubdidGroups> db_queryPrivateUniqPubdidGroups(List<String> pubdids) { AuthPolicyDb adb; synchronized(AuthPolicyDb.class) { //AuthPolicyDb.dbConnUrl = this.dbConnUrl; - AuthPolicyDb.dbUserName = this.dbUserName; - AuthPolicyDb.dbPassword = this.dbPassword; + //AuthPolicyDb.dbUserName = this.dbUserName; + //AuthPolicyDb.dbPassword = this.dbPassword; adb = new AuthPolicyDb(); } diff --git a/data-access/servlet/src/main/java/auth/authz/AuthPolicyDb.java b/data-access/servlet/src/main/java/auth/authz/AuthPolicyDb.java index 41f81e547c5eeac9f88042907091983bb3e9475b..03e9ff83f25b159cd6122ae7423dee931c310953 100644 --- a/data-access/servlet/src/main/java/auth/authz/AuthPolicyDb.java +++ b/data-access/servlet/src/main/java/auth/authz/AuthPolicyDb.java @@ -32,11 +32,8 @@ public class AuthPolicyDb private static final Logger LOGGER = Logger.getLogger(AuthPolicyDb.class.getName()); private static final String DB_DRIVER = "org.postgresql.Driver"; - private static final Settings settings = Settings.getInstance(); - static public Settings.DBConn dbconn = settings.dbConn; -// static public String dbConnUrl; - static public String dbUserName; - static public String dbPassword; + private static final AuthZSettings settings = AuthZSettings.getInstance("authpolicy.properties"); + static public AuthZSettings.DBConn dbconn = settings.dbConn; private Connection conn; private Statement st; diff --git a/data-access/servlet/src/main/java/auth/authz/webapi/AuthZFilter.java b/data-access/servlet/src/main/java/auth/authz/webapi/AuthZFilter.java index d24628f832313f5848544073795b31c1be3de525..25b946497297358c20ef39c8f30f041e70c974f3 100644 --- a/data-access/servlet/src/main/java/auth/authz/webapi/AuthZFilter.java +++ b/data-access/servlet/src/main/java/auth/authz/webapi/AuthZFilter.java @@ -95,7 +95,7 @@ class AuthZ } String[] pubdidArr = pubdidList.toArray(new String[pubdidList.size()]); String[] authorized_pubdids; - authorized_pubdids = auth.filterAuthorized(pubdidArr, settings.dbConn.uri(), settings.dbConn.userName(), settings.dbConn.password()); + authorized_pubdids = auth.filterAuthorized(pubdidArr); /* If multiplicity allowed (and in mcutout/merge): * if one or more of pubdids not-authorized -> all request not authorized diff --git a/docker/start-soda.sh.soda b/docker/start-soda.sh.soda index 018b52fb6bd23909d9a227d7824c3f1fb2e363d0..82e6ce813d6eb538c5f2dd5b8f3710664ef44a85 100755 --- a/docker/start-soda.sh.soda +++ b/docker/start-soda.sh.soda @@ -114,8 +114,8 @@ else echo "db_schema=$AUTHZ_DB_SCHEMA" echo "db_user_name=$AUTHZ_DB_USERNAME" echo "db_password=$AUTHZ_DB_PASSWORD" - } >> $WEBAPP_DIR/WEB-INF/classes/cutout.properties - # cp $WEBAPP_DIR/WEB-INF/web-cutout-ia2token.xml $WEBAPP_DIR/WEB-INF/web.xml + } > $WEBAPP_DIR/WEB-INF/classes/authpolicy.properties + #cp $WEBAPP_DIR/WEB-INF/web-cutout-ia2token.xml $WEBAPP_DIR/WEB-INF/web.xml fi