From 570884a05452622ef9b70796fa5b97101683d953 Mon Sep 17 00:00:00 2001 From: Makayla Shepherd <mshepherd@usgs.gov> Date: Thu, 29 Mar 2018 15:25:53 -0700 Subject: [PATCH] Update CONTRIBUTING.md --- CONTRIBUTING.md | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index d871cb00be..5806bb5c9b 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -14,7 +14,7 @@ The following is a set of guidelines for contributing to ISIS3. * [Working on an existing enhancement](#working-on-an-enhancement) * [Working on a new issue or enhancement](#working-on-a-new-issue) -[Guidelines for Code Base Contributions](#guidelines-for-code-base-contributtions) +[Code Base Contribution Guidelines](#code-base-contribution-guidelines) [What can I expect from the ISIS3 development team](#What-can-I-expect-from-the-ISIS3-development-team) * [Response time](#Response-time) @@ -39,8 +39,11 @@ There's lots of ways to contribute to ISIS3. 2. Propose a solution on the redmine issue. 3. Work with an ISIS3 developer, the issue reporter, and any other interested parties to get feedback on your solution. This may be an iterative process. 4. Add an [impact statement](https://isis.astrogeology.usgs.gov/fixit/projects/isis/wiki/Impact_Statement) to the redmine issue. If you don't have the permission to do this, please make a note on the issue with the impact statement. -5. Make the changes on your fork of the ISIS3 main GitHub repo. Follow the [Guidelines for contributing to the code base](#guidelines-for-contributing-to-the-code-base). +5. Make the changes on your fork of the ISIS3 main GitHub repo. Follow the [Code Base Contribution Guidelines](#code-base-contribution-guidelines). 6. Follow the Developer's Checklist to ensure your changes are ready for review. 7. Make a pull request. Include the redmine issue number in the title of the pull request. Use the "Fixes #0000" format. 8. Work with your code reviewer, tester, and reporter to improve your changes. Your pull request will not be merged in until all parties approve the changes. 9. Check in your test data. If you are an outside contributer, work with your code reviewer to ensure your tests and test data get checked in. + +## Code Base Contribution Guidelines + -- GitLab