From c0fded36c3a6428c515a933a05171441f74b7258 Mon Sep 17 00:00:00 2001
From: Amy Stamile <74275278+amystamile-usgs@users.noreply.github.com>
Date: Fri, 20 Dec 2024 07:01:14 -0700
Subject: [PATCH] kaguyatc2isis invalid BandBin values (#5692)
---
CHANGELOG.md | 1 +
isis/src/kaguya/apps/kaguyatc2isis/kaguyatc2isis.cpp | 4 ++--
isis/tests/FunctionalTestsKaguyatc2isis.cpp | 8 ++++----
3 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 6b447be92a..25b642f492 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -64,6 +64,7 @@ file. Slightly modified the FunctionalTestJigsawBundleXYZ ctest accordingly. Iss
- Fixed PHOTOMET not accepting backplanes [#5281](https://github.com/DOI-USGS/ISIS3/issues/5281)
- Fixed dstripe parallel test failing by converting tests to gtests [#5613](https://github.com/DOI-USGS/ISIS3/issues/5613)
- Fixed autoseed SeedDomain = SampleLine only working for first overlap [#5673](https://github.com/DOI-USGS/ISIS3/issues/5673)
+- Fixed kaguyatc2isis invalid BandBin values [#5629](https://github.com/DOI-USGS/ISIS3/issues/5629)
## [8.3.0] - 2024-09-30
diff --git a/isis/src/kaguya/apps/kaguyatc2isis/kaguyatc2isis.cpp b/isis/src/kaguya/apps/kaguyatc2isis/kaguyatc2isis.cpp
index 4b3be07ebe..d90d4c1de3 100644
--- a/isis/src/kaguya/apps/kaguyatc2isis/kaguyatc2isis.cpp
+++ b/isis/src/kaguya/apps/kaguyatc2isis/kaguyatc2isis.cpp
@@ -284,8 +284,8 @@ namespace Isis {
// Add the BandBin group
PvlGroup bandBinGroup("BandBin");
bandBinGroup += PvlKeyword("FilterName", "BroadBand");
- bandBinGroup += PvlKeyword("Center", "640nm");
- bandBinGroup += PvlKeyword("Width", "420nm");
+ bandBinGroup += PvlKeyword("Center", "640", "nanometers");
+ bandBinGroup += PvlKeyword("Width", "420", "nanometers");
outcube->putGroup(bandBinGroup);
}
diff --git a/isis/tests/FunctionalTestsKaguyatc2isis.cpp b/isis/tests/FunctionalTestsKaguyatc2isis.cpp
index 342db9d996..741a93a434 100644
--- a/isis/tests/FunctionalTestsKaguyatc2isis.cpp
+++ b/isis/tests/FunctionalTestsKaguyatc2isis.cpp
@@ -77,8 +77,8 @@ TEST(kaguyatc2isisTest, kaguyatc2isisTestDefault) {
// Bandbin Group
PvlGroup &bandbin = isisLabel->findGroup("BandBin", Pvl::Traverse);
- ASSERT_EQ(bandbin["Center"][0], "640nm");
- ASSERT_EQ(bandbin["Width"][0], "420nm");
+ ASSERT_EQ(bandbin["Center"][0], "640");
+ ASSERT_EQ(bandbin["Width"][0], "420");
// Kernels Group
PvlGroup &kern = isisLabel->findGroup("Kernels", Pvl::Traverse);
@@ -150,8 +150,8 @@ TEST(kaguyatc2isisTest, kaguyatc2isisTestSpSupport) {
// Bandbin Group
PvlGroup &bandbin = isisLabel->findGroup("BandBin", Pvl::Traverse);
- ASSERT_EQ(bandbin["Center"][0], "640nm");
- ASSERT_EQ(bandbin["Width"][0], "420nm");
+ ASSERT_EQ(bandbin["Center"][0], "640");
+ ASSERT_EQ(bandbin["Width"][0], "420");
// Kernels Group
PvlGroup &kern = isisLabel->findGroup("Kernels", Pvl::Traverse);
--
GitLab