From ef7b5144e374aba7a1b56236c3a4f75f6a595b87 Mon Sep 17 00:00:00 2001
From: acpaquette <acpaquette@usgs.gov>
Date: Fri, 16 Apr 2021 11:37:32 -0700
Subject: [PATCH] Updated FindFeatures Logging (#4399)

* Fixed logging for findfeatures

* Corrected log write check in findfeatures application

* Updated the change log
---
 CHANGELOG.md                                        | 1 +
 isis/src/control/apps/findfeatures/findfeatures.cpp | 3 +--
 isis/src/control/apps/findfeatures/main.cpp         | 7 +++----
 3 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index c9bb1d4275..0e90cd5136 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -50,6 +50,7 @@ release.
 - Fixed hardcoded file naming in the hijitter app dealing with output from pipeline. [#4372](https://github.com/USGS-Astrogeology/ISIS3/pull/4372)
 - Fixed "About Qview" to point to website documentation. [4333](https://github.com/USGS-Astrogeology/ISIS3/issues/4333)
 - Fixed bug where the time bias was not being added to the ephemeris times in ckwriter. [4129](https://github.com/USGS-Astrogeology/ISIS3/issues/4129)
+- Fixed logging in FindFeatures where we were trying to get a non-existent Pvl group from the Pvl log. [#4375](https://github.com/USGS-Astrogeology/ISIS3/issues/4375)
 
 ### Changed
 
diff --git a/isis/src/control/apps/findfeatures/findfeatures.cpp b/isis/src/control/apps/findfeatures/findfeatures.cpp
index 5ef5ff0038..45b4da3656 100644
--- a/isis/src/control/apps/findfeatures/findfeatures.cpp
+++ b/isis/src/control/apps/findfeatures/findfeatures.cpp
@@ -81,8 +81,7 @@ namespace Isis{
         }
         else {
           if (log){
-            PvlGroup results = data.findGroup("Results");
-            log->addGroup(results);
+            log->addObject(data);
           }
         }
       }
diff --git a/isis/src/control/apps/findfeatures/main.cpp b/isis/src/control/apps/findfeatures/main.cpp
index dd75cdc0e5..be727f2cf7 100644
--- a/isis/src/control/apps/findfeatures/main.cpp
+++ b/isis/src/control/apps/findfeatures/main.cpp
@@ -33,10 +33,9 @@ void IsisMain() {
     Application::Log(*grpIt);
   }
 
-  PvlGroup results = appLog.findGroup("Results");
-  if( ui.WasEntered("TO") && ui.IsInteractive() ) {
+  Pvl results;
+  if( (ui.GetBoolean("LISTALL") || ui.GetBoolean("LISTSPEC")) && ui.IsInteractive() ) {
+    results.addObject(appLog.findObject("FeatureAlgorithms"));
     Application::GuiLog(results);
   }
-
-  SessionLog::TheLog().AddResults(results);
 }
-- 
GitLab