From b644fd5aca8fedbeb5379386d8343bce4c9093c7 Mon Sep 17 00:00:00 2001
From: Kelvin Rodriguez <krodriguez@usgs.gov>
Date: Tue, 17 Sep 2024 14:02:21 -0700
Subject: [PATCH] passing tests (#618)

* passing tests

* removed upload coverage since we dont even pay attention to it anyways right now
---
 .github/workflows/ci_testing.yml | 14 +++++++-------
 ale/drivers/apollo_drivers.py    | 14 +++++++++++++-
 2 files changed, 20 insertions(+), 8 deletions(-)

diff --git a/.github/workflows/ci_testing.yml b/.github/workflows/ci_testing.yml
index c91ebcf..71fbd85 100644
--- a/.github/workflows/ci_testing.yml
+++ b/.github/workflows/ci_testing.yml
@@ -52,13 +52,13 @@ jobs:
         run: |
           cd build
           ctest -VV
-      - name: Upload Coverage
-        uses: codecov/codecov-action@v1
-        with:
-          token: ${{ secrets.CODECOV_TOKEN }}
-          fail_ci_if_error: true
-          verbose: true
-        if: matrix.os == 'ubuntu-latest' && matrix.python-version == '3.9'
+      # - name: Upload Coverage
+      #   uses: codecov/codecov-action@v1
+      #   with:
+      #     token: ${{ secrets.CODECOV_TOKEN }}
+      #     fail_ci_if_error: true
+      #     verbose: true
+      #   if: matrix.os == 'ubuntu-latest' && matrix.python-version == '3.9'
 
   Build-Docs:
     runs-on: ubuntu-latest
diff --git a/ale/drivers/apollo_drivers.py b/ale/drivers/apollo_drivers.py
index 927915e..ff800ea 100644
--- a/ale/drivers/apollo_drivers.py
+++ b/ale/drivers/apollo_drivers.py
@@ -142,7 +142,7 @@ class ApolloMetricIsisLabelNaifSpiceDriver(Framer, IsisLabel, NaifSpice, NoDisto
 class ApolloPanIsisLabelIsisSpiceDriver(LineScanner, IsisLabel, IsisSpice, NoDistortion, Driver):
 
     @property
-    def instrument_name(self):
+    def instrument_id(self):
         """
         The name of the instrument.
 
@@ -158,6 +158,18 @@ class ApolloPanIsisLabelIsisSpiceDriver(LineScanner, IsisLabel, IsisSpice, NoDis
         return id_lookup[super().instrument_id]
 
 
+    @property
+    def instrument_name(self):
+        """
+        The name of the instrument.
+
+        Returns
+        -------
+        str
+          The short text name for the instrument
+        """
+        return "APOLLO PANORAMIC CAMERA"
+
     @property
     def sensor_model_version(self):
         """
-- 
GitLab