From 667bf31b6d84b0b6bfd8f6b338b1cf93d93c3590 Mon Sep 17 00:00:00 2001
From: Giovanni La Mura <giovanni.lamura@inaf.it>
Date: Fri, 12 Apr 2024 13:55:07 +0200
Subject: [PATCH] Force error detection on ratios if warning threshold is 0

---
 src/scripts/pycompare.py | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/src/scripts/pycompare.py b/src/scripts/pycompare.py
index 4fcdc121..82448837 100755
--- a/src/scripts/pycompare.py
+++ b/src/scripts/pycompare.py
@@ -220,29 +220,30 @@ def compare_lines(f_line, c_line, config, line_num=0, num_len=4, log_file=None):
                             + c_groups[si] + "</code></span><code>" + c_line[c_ends[si]:c_starts[si + 1]]
                         )
             if (len(severities) > 0):
-                # Single errror test modification
+                # Single error test modification
                 if (severities[-1] == 1): noisy += 1
                 elif (severities[-1] == 2): warnings += 1
                 elif (severities[-1] == 3):
                     split_c_line = c_line.split('/')
-                    if (len(split_c_line) != 2): errors += 1
+                    if (config['warning_threshold'] == 0.0): errors += 1
+                    elif (len(split_c_line) != 2): errors += 1
             if log_file is not None:
                 if (len(severities) > 0):
                     if (severities[-1] == 0):
                         log_line = (
                             log_line + c_groups[-1] + c_line[c_ends[-1]:len(c_line) - 1]
                         )
-                    elif (severities[-1] == 1):
+                    if (severities[-1] == 1):
                         log_line = (
                             log_line + "</code><span style=\"font-weight: bold; color: rgb(0,185,0)\"><code>"
                             + c_groups[-1] + "</code></span><code>" + c_line[c_ends[-1]:len(c_line) - 2]
                         )
-                    elif (severities[-1] == 2):
+                    if (severities[-1] == 2):
                         log_line = (
                             log_line + "</code><span style=\"font-weight: bold; color: rgb(0,0,255)\"><code>"
                             + c_groups[-1] + "</code></span><code>" + c_line[c_ends[-1]:len(c_line) - 2]
                         )
-                    elif (severities[-1] == 3):
+                    if (severities[-1] == 3):
                         split_c_line = c_line.split('/')
                         if (len(split_c_line) == 2):
                             log_line = (
-- 
GitLab