diff --git a/gms-client/gms-cli/src/main/java/it/inaf/ia2/gms/cli/CLI.java b/gms-client/gms-cli/src/main/java/it/inaf/ia2/gms/cli/CLI.java index 118e2be41f3186f3f9ba4b9fd6310c5e2fa8a64e..71b413bee175693c0df3ccc602667e6106a26f5b 100644 --- a/gms-client/gms-cli/src/main/java/it/inaf/ia2/gms/cli/CLI.java +++ b/gms-client/gms-cli/src/main/java/it/inaf/ia2/gms/cli/CLI.java @@ -4,6 +4,7 @@ import it.inaf.ia2.client.ClientException; import it.inaf.ia2.gms.client.GmsClient; import it.inaf.ia2.gms.client.model.Permission; import it.inaf.ia2.rap.client.RapClient; +import it.inaf.ia2.rap.data.AccessTokenResponse; import java.io.File; import java.io.FileInputStream; import java.io.IOException; @@ -106,11 +107,12 @@ public class CLI { if (token != null) { client.setAccessToken(token); - } else { + } else { RapClient rapClient = new RapClient(rapBaseUrl) .setClientId(clientId) - .setClientSecret(clientSecret); - client.setAccessToken(rapClient.getAccessTokenFromClientCredentials()); + .setClientSecret(clientSecret); + AccessTokenResponse accessTokenResponse = rapClient.getAccessTokenFromClientCredentials(); + client.setAccessToken(accessTokenResponse.getAccessToken()); } } diff --git a/gms/src/main/java/it/inaf/ia2/gms/service/GroupNameService.java b/gms/src/main/java/it/inaf/ia2/gms/service/GroupNameService.java index be619b1700e66d1291ecfc174e50d7f5bd383ecb..fc9061874c2974d5989921741a63c45ed536754d 100644 --- a/gms/src/main/java/it/inaf/ia2/gms/service/GroupNameService.java +++ b/gms/src/main/java/it/inaf/ia2/gms/service/GroupNameService.java @@ -47,7 +47,7 @@ public class GroupNameService { List<String> names = new ArrayList<>(groupsDAO.getGroupCompleteNamesFromId(groupIds).values()); if (groupIds.contains("ROOT")) { - names.add("Root"); + names.add(getRoot().getName()); } Collections.sort(names); @@ -72,7 +72,7 @@ public class GroupNameService { Map<String, List<String>> result = new HashMap<>(); if (groupIds.contains("ROOT")) { - result.put("ROOT", Collections.singletonList("Root")); + result.put("ROOT", Collections.singletonList(getRoot().getName())); } for (Map.Entry<String, String> entry : groupsDAO.getGroupCompleteNamesFromId(groupIds).entrySet()) { diff --git a/gms/src/main/resources/application.properties b/gms/src/main/resources/application.properties index 3428af258478003b6ab781cd554b23699634b93b..5eaf82656ab17531f8a61e74d212f62cc66d3010 100644 --- a/gms/src/main/resources/application.properties +++ b/gms/src/main/resources/application.properties @@ -13,7 +13,6 @@ spring.datasource.url=jdbc:postgresql://localhost:5432/postgres spring.datasource.username=gms spring.datasource.password=gms -rap.ws-url=http://localhost/rap-ia2/ws support.contact.label=IA2 team support.contact.email=ia2@inaf.it diff --git a/gms/src/test/java/it/inaf/ia2/gms/manager/PermissionsManagerIntegrationTest.java b/gms/src/test/java/it/inaf/ia2/gms/manager/PermissionsManagerIntegrationTest.java index 93190b4c73ed43306a2784da6d1e51262bbb4f8e..b0b73601f1e7719528b9e88980b50f1815aa539b 100644 --- a/gms/src/test/java/it/inaf/ia2/gms/manager/PermissionsManagerIntegrationTest.java +++ b/gms/src/test/java/it/inaf/ia2/gms/manager/PermissionsManagerIntegrationTest.java @@ -62,7 +62,7 @@ public class PermissionsManagerIntegrationTest { // Create root GroupEntity root = new GroupEntity(); root.setId("ROOT"); - root.setName("Root"); + root.setName("ROOT"); root.setPath(""); root = groupsDAO.createGroup(root); diff --git a/gms/src/test/java/it/inaf/ia2/gms/service/GroupNameServiceTest.java b/gms/src/test/java/it/inaf/ia2/gms/service/GroupNameServiceTest.java index 2b4b74c84f830201b263fdb7241bebd94e554fdc..6b4b94643c51e5b0b9ec4b40049004b6bb85c0e7 100644 --- a/gms/src/test/java/it/inaf/ia2/gms/service/GroupNameServiceTest.java +++ b/gms/src/test/java/it/inaf/ia2/gms/service/GroupNameServiceTest.java @@ -8,11 +8,13 @@ import java.util.HashMap; import java.util.HashSet; import java.util.List; import java.util.Map; +import java.util.Optional; import java.util.Set; import static org.junit.Assert.assertEquals; import org.junit.Test; import org.junit.runner.RunWith; import static org.mockito.ArgumentMatchers.any; +import static org.mockito.ArgumentMatchers.eq; import org.mockito.InjectMocks; import org.mockito.Mock; import static org.mockito.Mockito.when; @@ -58,12 +60,20 @@ public class GroupNameServiceTest { when(groupsDAO.getGroupCompleteNamesFromId(any())).thenReturn(new HashMap<>()); + GroupEntity root = new GroupEntity(); + root.setId("ROOT"); + root.setName("ROOT"); + root.setPath(""); + + when(groupsDAO.findGroupById(eq("ROOT"))) + .thenReturn(Optional.of(root)); + List<Map.Entry<String, String>> groupsIdPath = new ArrayList<>(); groupsIdPath.add(new AbstractMap.SimpleEntry<>("ROOT", "")); Map<String, List<String>> names = groupNameService.getNamesFromIds(groupIds); assertEquals(1, names.size()); assertEquals(1, names.get("ROOT").size()); - assertEquals("Root", names.get("ROOT").get(0)); + assertEquals("ROOT", names.get("ROOT").get(0)); } } diff --git a/gms/src/test/java/it/inaf/ia2/gms/service/SearchServiceTest.java b/gms/src/test/java/it/inaf/ia2/gms/service/SearchServiceTest.java index 72b06ce8161daa4c1b08b6327346c1e410d77439..de6961a5760d8efaaa8ad737ac76181e0c35be4f 100644 --- a/gms/src/test/java/it/inaf/ia2/gms/service/SearchServiceTest.java +++ b/gms/src/test/java/it/inaf/ia2/gms/service/SearchServiceTest.java @@ -69,7 +69,7 @@ public class SearchServiceTest { List<String> names = new ArrayList<>(); switch (group.getId()) { case "ROOT": - names.add("Root"); + names.add("ROOT"); break; case "group1_id": names.add("Group 1"); @@ -169,7 +169,7 @@ public class SearchServiceTest { GroupEntity root = new GroupEntity(); root.setId("ROOT"); - root.setName("Root"); + root.setName("ROOT"); root.setPath(""); when(groupsManager.getRoot()).thenReturn(root);