From 1e5c3a27352de5f633e1acd474ed12da2b39fd69 Mon Sep 17 00:00:00 2001
From: Sonia Zorba <sonia.zorba@inaf.it>
Date: Wed, 14 Aug 2019 13:19:20 +0200
Subject: [PATCH] Bugfix in MySQLUserDAO: passed value by reference in the loop

---
 classes/datalayer/mysql/MySQLUserDAO.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/classes/datalayer/mysql/MySQLUserDAO.php b/classes/datalayer/mysql/MySQLUserDAO.php
index 8d2ba87..3b9768e 100644
--- a/classes/datalayer/mysql/MySQLUserDAO.php
+++ b/classes/datalayer/mysql/MySQLUserDAO.php
@@ -206,7 +206,7 @@ class MySQLUserDAO extends BaseMySQLDAO implements UserDAO {
 
         $stmt = $dbh->prepare($query);
 
-        foreach ($identifiers as $id) {
+        foreach ($identifiers as &$id) {
             $stmt->bindParam(':id_' . $id, $id);
         }
 
@@ -234,7 +234,7 @@ class MySQLUserDAO extends BaseMySQLDAO implements UserDAO {
 
             array_push($user->identities, $identity);
         }
-
+        
         $users = [];
         foreach ($userMap as $userId => $user) {
             array_push($users, $user);
-- 
GitLab