From a6be0ef71c09d247dec6dfa2aa1b58b0d250c536 Mon Sep 17 00:00:00 2001 From: Cristiano Urban Date: Wed, 14 Jul 2021 17:17:37 +0200 Subject: [PATCH] Pass logger object to 'Mailer' and 'TapeClient'. Signed-off-by: Cristiano Urban --- transfer_service/group_rw_executor.py | 2 +- transfer_service/import_executor.py | 15 ++++++------ transfer_service/mailer.py | 27 +++++++++++---------- transfer_service/retrieve_cleaner.py | 3 --- transfer_service/retrieve_executor.py | 17 ++++++------- transfer_service/retrieve_preprocessor.py | 2 +- transfer_service/store_executor.py | 15 ++++++------ transfer_service/store_preprocessor.py | 2 +- transfer_service/tape_client.py | 29 ++++++++++++----------- 9 files changed, 57 insertions(+), 55 deletions(-) diff --git a/transfer_service/group_rw_executor.py b/transfer_service/group_rw_executor.py index 214c2fb..d41603a 100644 --- a/transfer_service/group_rw_executor.py +++ b/transfer_service/group_rw_executor.py @@ -73,7 +73,7 @@ class GroupRwExecutor(TaskExecutor): self.dbConn.setEndTime(self.jobId) # Send e-mail notification - m = Mailer() + m = Mailer(self.logger) m.addRecipient(self.adminEmail) userEmail = self.dbConn.getUserEmail(self.userId) if userEmail != self.adminEmail: diff --git a/transfer_service/import_executor.py b/transfer_service/import_executor.py index d861740..4ee7897 100644 --- a/transfer_service/import_executor.py +++ b/transfer_service/import_executor.py @@ -30,12 +30,7 @@ class ImportExecutor(TaskExecutor): params.getint("port"), params["db"], 1, - 1) - params = config.loadSection("spectrum_archive") - self.tapeClient = TapeClient(params["host"], - params.getint("port"), - params["user"], - params["pkey_file_path"]) + 1) params = config.loadSection("mail") self.adminEmail = params["admin_email"] params = config.loadSection("logging") @@ -51,6 +46,12 @@ class ImportExecutor(TaskExecutor): self.logger.addHandler(redisLogHandler) self.logger.addHandler(logStreamHandler) self.resDir = params["res_dir"] + params = config.loadSection("spectrum_archive") + self.tapeClient = TapeClient(params["host"], + params.getint("port"), + params["user"], + params["pkey_file_path"], + self.logger) self.systemUtils = SystemUtils() self.jobObj = None self.jobId = None @@ -177,7 +178,7 @@ class ImportExecutor(TaskExecutor): self.dbConn.setEndTime(self.jobId) # Send e-mail notification - m = Mailer() + m = Mailer(self.logger) m.addRecipient(self.adminEmail) msg = f""" [VOSpace import procedure summary] diff --git a/transfer_service/mailer.py b/transfer_service/mailer.py index 14ed8ac..3c2da9f 100644 --- a/transfer_service/mailer.py +++ b/transfer_service/mailer.py @@ -15,25 +15,26 @@ from smtplib import SMTPException class Mailer(object): - def __init__(self): + def __init__(self, logger): config = Config("/etc/vos_ts/vos_ts.conf") params = config.loadSection("mail") self.smtpServer = params["smtp_server"] self.smtpPort = params.getint("smtp_port") self.sender = params["no_reply_email"] self.enabled = params.getboolean("enable_notifications") - params = config.loadSection("logging") - self.logger = logging.getLogger(__name__) - logLevel = "logging." + params["log_level"] - logFormat = params["log_format"] - logFormatter = logging.Formatter(logFormat) - self.logger.setLevel(eval(logLevel)) - redisLogHandler = RedisLogHandler() - logStreamHandler = logging.StreamHandler() - logStreamHandler.setFormatter(logFormatter) - redisLogHandler.setFormatter(logFormatter) - self.logger.addHandler(redisLogHandler) - self.logger.addHandler(logStreamHandler) + self.logger = logger + #params = config.loadSection("logging") + #self.logger = logging.getLogger(__name__) + #logLevel = "logging." + params["log_level"] + #logFormat = params["log_format"] + #logFormatter = logging.Formatter(logFormat) + #self.logger.setLevel(eval(logLevel)) + #redisLogHandler = RedisLogHandler() + #logStreamHandler = logging.StreamHandler() + #logStreamHandler.setFormatter(logFormatter) + #redisLogHandler.setFormatter(logFormatter) + #self.logger.addHandler(redisLogHandler) + #self.logger.addHandler(logStreamHandler) self.recipients = [] self.message = None diff --git a/transfer_service/retrieve_cleaner.py b/transfer_service/retrieve_cleaner.py index 68cf531..7229cab 100644 --- a/transfer_service/retrieve_cleaner.py +++ b/transfer_service/retrieve_cleaner.py @@ -8,7 +8,6 @@ import shutil from config import Config from db_connector import DbConnector -from mailer import Mailer from redis_log_handler import RedisLogHandler from task_executor import TaskExecutor @@ -31,8 +30,6 @@ class RetrieveCleaner(TaskExecutor): params = config.loadSection("async_recall") self.days = params.getint("days") self.seconds = params.getint("hours") * 3600 + params.getint("minutes") * 60 + params.getint("seconds") - params = config.loadSection("mail") - self.adminEmail = params["admin_email"] params = config.loadSection("logging") self.logger = logging.getLogger(__name__) logLevel = "logging." + params["log_level"] diff --git a/transfer_service/retrieve_executor.py b/transfer_service/retrieve_executor.py index 4ecbe1b..92f8546 100644 --- a/transfer_service/retrieve_executor.py +++ b/transfer_service/retrieve_executor.py @@ -40,13 +40,7 @@ class RetrieveExecutor(TaskExecutor): def __init__(self): self.type = "retrieve_executor" self.systemUtils = SystemUtils() - config = Config("/etc/vos_ts/vos_ts.conf") - params = config.loadSection("spectrum_archive") - self.tapeClient = TapeClient(params["host"], - params.getint("port"), - params["user"], - params["pkey_file_path"]) - self.tapePool = params["tape_pool"] + config = Config("/etc/vos_ts/vos_ts.conf") params = config.loadSection("transfer_node") self.storageRetrievePath = params["retrieve_path"] params = config.loadSection("file_catalog") @@ -75,6 +69,13 @@ class RetrieveExecutor(TaskExecutor): redisLogHandler.setFormatter(logFormatter) self.logger.addHandler(redisLogHandler) self.logger.addHandler(logStreamHandler) + params = config.loadSection("spectrum_archive") + self.tapePool = params["tape_pool"] + self.tapeClient = TapeClient(params["host"], + params.getint("port"), + params["user"], + params["pkey_file_path"], + self.logger) self.storageType = None self.jobObj = None self.jobId = None @@ -278,7 +279,7 @@ class RetrieveExecutor(TaskExecutor): self.jobObj.jobInfo["destPathList"] = self.destPathList.copy() # Send e-mail notification - m = Mailer() + m = Mailer(self.logger) m.addRecipient(self.adminEmail) userEmail = self.dbConn.getUserEmail(self.jobObj.ownerId) diff --git a/transfer_service/retrieve_preprocessor.py b/transfer_service/retrieve_preprocessor.py index 0442da5..0165d68 100644 --- a/transfer_service/retrieve_preprocessor.py +++ b/transfer_service/retrieve_preprocessor.py @@ -50,7 +50,7 @@ class RetrievePreprocessor(TaskExecutor): def update(self): # Send e-mail notification - m = Mailer() + m = Mailer(self.logger) m.addRecipient(self.adminEmail) userEmail = self.dbConn.getUserEmail(self.jobObj.ownerId) diff --git a/transfer_service/store_executor.py b/transfer_service/store_executor.py index 9726453..7fd9910 100644 --- a/transfer_service/store_executor.py +++ b/transfer_service/store_executor.py @@ -21,12 +21,7 @@ class StoreExecutor(TaskExecutor): def __init__(self): self.type = "store_executor" - config = Config("/etc/vos_ts/vos_ts.conf") - params = config.loadSection("spectrum_archive") - self.tapeClient = TapeClient(params["host"], - params.getint("port"), - params["user"], - params["pkey_file_path"]) + config = Config("/etc/vos_ts/vos_ts.conf") params = config.loadSection("transfer_node") self.storageStorePath = params["store_path"] params = config.loadSection("file_catalog") @@ -54,6 +49,12 @@ class StoreExecutor(TaskExecutor): self.logger.addHandler(redisLogHandler) self.logger.addHandler(logStreamHandler) self.resDir = params["res_dir"] + params = config.loadSection("spectrum_archive") + self.tapeClient = TapeClient(params["host"], + params.getint("port"), + params["user"], + params["pkey_file_path"], + self.logger) self.jobObj = None self.jobId = None self.username = None @@ -116,7 +117,7 @@ class StoreExecutor(TaskExecutor): self.dbConn.setEndTime(self.jobId) # Send e-mail notification - m = Mailer() + m = Mailer(self.logger) m.addRecipient(self.adminEmail) self.userEmail = self.dbConn.getUserEmail(self.userId) if self.userEmail != self.adminEmail: diff --git a/transfer_service/store_preprocessor.py b/transfer_service/store_preprocessor.py index d722877..922e1a4 100644 --- a/transfer_service/store_preprocessor.py +++ b/transfer_service/store_preprocessor.py @@ -226,7 +226,7 @@ class StorePreprocessor(TaskExecutor): self.dbConn.setPhase(self.jobId, "QUEUED") # Send e-mail notification - m = Mailer() + m = Mailer(self.logger) m.addRecipient(self.adminEmail) userEmail = self.dbConn.getUserEmail(self.jobObj.ownerId) diff --git a/transfer_service/tape_client.py b/transfer_service/tape_client.py index 70b79a0..9298f07 100644 --- a/transfer_service/tape_client.py +++ b/transfer_service/tape_client.py @@ -17,20 +17,21 @@ class TapeClient(object): EEADM = "/opt/ibm/ltfsee/bin/eeadm" # Constructor - def __init__(self, host, port, user, keyFile): - config = Config("/etc/vos_ts/vos_ts.conf") - params = config.loadSection("logging") - self.logger = logging.getLogger(__name__) - logLevel = "logging." + params["log_level"] - logFormat = params["log_format"] - logFormatter = logging.Formatter(logFormat) - self.logger.setLevel(eval(logLevel)) - redisLogHandler = RedisLogHandler() - logStreamHandler = logging.StreamHandler() - logStreamHandler.setFormatter(logFormatter) - redisLogHandler.setFormatter(logFormatter) - self.logger.addHandler(redisLogHandler) - self.logger.addHandler(logStreamHandler) + def __init__(self, host, port, user, keyFile, logger): + #config = Config("/etc/vos_ts/vos_ts.conf") + #params = config.loadSection("logging") + #self.logger = logging.getLogger(__name__) + #logLevel = "logging." + params["log_level"] + #logFormat = params["log_format"] + #logFormatter = logging.Formatter(logFormat) + #self.logger.setLevel(eval(logLevel)) + #redisLogHandler = RedisLogHandler() + #logStreamHandler = logging.StreamHandler() + #logStreamHandler.setFormatter(logFormatter) + #redisLogHandler.setFormatter(logFormatter) + #self.logger.addHandler(redisLogHandler) + #self.logger.addHandler(logStreamHandler) + self.logger = logger self.host = host self.port = port self.user = user -- GitLab