From e81dc51afde48a5e6799746dbc845cca6febc530 Mon Sep 17 00:00:00 2001
From: gmantele <gmantele@ari.uni-heidelberg.de>
Date: Thu, 10 Apr 2014 12:19:50 +0200
Subject: [PATCH] TAP: Tag an upload & DBConnection issue to fix!

---
 src/tap/ADQLExecutor.java | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/tap/ADQLExecutor.java b/src/tap/ADQLExecutor.java
index dd92dad..6b70b0c 100644
--- a/src/tap/ADQLExecutor.java
+++ b/src/tap/ADQLExecutor.java
@@ -100,6 +100,8 @@ public class ADQLExecutor< R > {
 			logger.info("JOB " + report.jobID + "\tLoading uploaded tables (" + tables.length + ")...");
 			long start = System.currentTimeMillis();
 			try{
+				/* TODO Problem with the DBConnection! One is created here for the Uploader (and dbConn is set) and closed by its uploadTables function (but dbConn is not set to null).
+				 * Ideally, the connection should not be close, or at least dbConn should be set to null just after. */
 				uploadSchema = service.getFactory().createUploader(getDBConnection()).upload(tables);
 			}finally{
 				TAPParameters.deleteUploadedTables(tables);
-- 
GitLab