Skip to content
Snippets Groups Projects
Commit 314fa342 authored by Patrick Dowler's avatar Patrick Dowler
Browse files

ichanged getGroup to use searchForEntry with base = groupDN

parent 18665865
No related branches found
No related tags found
No related merge requests found
...@@ -1012,17 +1012,17 @@ public class LdapGroupDAO<T extends Principal> extends LdapDAO ...@@ -1012,17 +1012,17 @@ public class LdapGroupDAO<T extends Principal> extends LdapDAO
logger.debug("getGroup: " + groupDN.toNormalizedString()); logger.debug("getGroup: " + groupDN.toNormalizedString());
Filter filter = Filter.createNOTFilter(Filter.createPresenceFilter("nsaccountlock")); Filter filter = Filter.createNOTFilter(Filter.createPresenceFilter("nsaccountlock"));
filter = Filter.createANDFilter(filter, //filter = Filter.createANDFilter(filter,
Filter.createEqualityFilter("entrydn", groupDN.toNormalizedString())); // Filter.createEqualityFilter("entrydn", groupDN.toNormalizedString()));
SearchRequest searchRequest = new SearchRequest( SearchRequest searchRequest = new SearchRequest(
config.getGroupsDN(), SearchScope.SUB, filter, GROUP_ATTRS); groupDN.toNormalizedString(), SearchScope.SUB, filter, GROUP_ATTRS);
searchRequest.addControl( searchRequest.addControl(
new ProxiedAuthorizationV2RequestControl("dn:" + new ProxiedAuthorizationV2RequestControl("dn:" +
getSubjectDN().toNormalizedString())); getSubjectDN().toNormalizedString()));
SearchResult result = getConnection().search(searchRequest); SearchResultEntry result = getConnection().searchForEntry(searchRequest);
if (result == null) if (result == null)
{ {
...@@ -1030,18 +1030,18 @@ public class LdapGroupDAO<T extends Principal> extends LdapDAO ...@@ -1030,18 +1030,18 @@ public class LdapGroupDAO<T extends Principal> extends LdapDAO
logger.debug(msg); logger.debug(msg);
throw new GroupNotFoundException(groupDN.toNormalizedString()); throw new GroupNotFoundException(groupDN.toNormalizedString());
} }
if (result.getEntryCount() == 0) //if (result.getEntryCount() == 0)
throw new GroupNotFoundException(groupDN.toString()); // throw new GroupNotFoundException(groupDN.toString());
SearchResultEntry sre = result.getSearchEntries().get(0); //SearchResultEntry sre = result.getSearchEntries().get(0);
if (sre.getAttribute("nsaccountlock") != null) if (result.getAttribute("nsaccountlock") != null)
{ {
// TODO: logger.error() + throw GroupNotFoundException instead? // TODO: logger.error() + throw GroupNotFoundException instead?
throw new RuntimeException("BUG: found group with nsaccountlock set: " + groupDN.toString()); throw new RuntimeException("BUG: found group with nsaccountlock set: " + groupDN.toString());
} }
Group g = createGroup(sre); Group g = createGroup(result);
logger.debug("found: " + g.getID()); logger.debug("found: " + g.getID());
return g; return g;
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment