-
- Downloads
Fix findfeatures matrix inversion issues and improve FastGeom performance (#4772)
* findfeatures bug fixes and improvements * Fix matrix inversion error on empty matrix. (Fixes #4639) * Identify images that fail FastGeom transform and exclude from matching. * Add TONOGEOM parameter to write failed file loads or FastGeom error file list if the transform cannot be determined * Improve FastGeom transform algorithm using new radial point mapping scheme * Add more debugging output to help diagnose problem images/procedures * findfeatures - add Grid algorithm to FastGeom * findfeatures mod to add Grid algorithm to FastGeom class * Improved Grid algorithm by computing proper starting iteration to statisfy fastgeompoints request * Added additional parameterization of Grid algorithm * Reorganized mapping process to consolidate Radial and Grid algorithms in FastGeom * findfeatures modifications after Astro code review findfeatures modifications: * Refactored FastGeom separating large sections of the compute() methods * Redesigned the the radial algorithm for easier user configuration * Added sanity checks avoid bad geometric correspondences * Added GLOBALS parameters for easy configuration of FastGeom algorithms at runtime * Fixed existing findfeatures test - error text The ThreeImageNetwork.FunctionalTestFindfeaturesErrorNoInput expects an error to be thrown with spectific text. The text in findfeatures.cpp was changed in this PR. It fixes the existing findfeatures test suite. * FastGeom.cpp updated to better accomodate testing * Add findfeatures Radial/Grid config files for test * Updated findfeatures test for Grid/Radial algos * Fixed cnetwinnow test that created misplaced files The cnetwinnow test needs tempDir().path() prepended to the “file_prefix” parameter to properly place the output files in the teardown directory. * Small adjustment to new findfeatures tests * Fixes/improvements to findfeature code - Improved reporting of parameterizations of findfeatures - Prevent creation of empty TONOTMATCH file when none are detected * Significant modifications/improvements to docs - Added two new examples demonstrating/documenting the use of FASTGEOM algorithm, parameterization using GLOBALS and how to produce a regional mosaic using findfeatures with batch scripts. - Reviewed, clarified and improved findfeatures program documentation * Updated the change log * Updates to findfeatures PR #4772 - Modified findfeatures.xml documentation to address PR review feedback - Fixed use of projected images which wasn’t working due to improper instantiation of the cube projection object - Updated CHANGELOG.md to better categorize all changes in this PR * Removed scripts in example 4 of findfeatures docs - Per request via USGS review, removed the Bash shell scripts that produce the results of example 4 - Removed the $ISISROOT/appdata/templates/findfeatures/mosaics containing the scripts - Updated documentation in findfeatures.xml accordingly - Updated CHANGELOG.md accordingly
Showing
- CHANGELOG.md 13 additions, 0 deletionsCHANGELOG.md
- isis/appdata/templates/findfeatures/findfeatures_fastgeom_defaults.pvl 40 additions, 0 deletions...templates/findfeatures/findfeatures_fastgeom_defaults.pvl
- isis/src/control/apps/findfeatures/FastGeom.cpp 647 additions, 31 deletionsisis/src/control/apps/findfeatures/FastGeom.cpp
- isis/src/control/apps/findfeatures/FastGeom.h 47 additions, 2 deletionsisis/src/control/apps/findfeatures/FastGeom.h
- isis/src/control/apps/findfeatures/FeatureAlgorithmFactory.cpp 25 additions, 1 deletion...src/control/apps/findfeatures/FeatureAlgorithmFactory.cpp
- isis/src/control/apps/findfeatures/FeatureAlgorithmFactory.h 2 additions, 0 deletionsisis/src/control/apps/findfeatures/FeatureAlgorithmFactory.h
- isis/src/control/apps/findfeatures/GenericTransform.cpp 57 additions, 9 deletionsisis/src/control/apps/findfeatures/GenericTransform.cpp
- isis/src/control/apps/findfeatures/GenericTransform.h 12 additions, 1 deletionisis/src/control/apps/findfeatures/GenericTransform.h
- isis/src/control/apps/findfeatures/ImageSource.cpp 22 additions, 19 deletionsisis/src/control/apps/findfeatures/ImageSource.cpp
- isis/src/control/apps/findfeatures/ImageSource.h 25 additions, 2 deletionsisis/src/control/apps/findfeatures/ImageSource.h
- isis/src/control/apps/findfeatures/MatchMaker.cpp 72 additions, 21 deletionsisis/src/control/apps/findfeatures/MatchMaker.cpp
- isis/src/control/apps/findfeatures/MatchMaker.h 10 additions, 1 deletionisis/src/control/apps/findfeatures/MatchMaker.h
- isis/src/control/apps/findfeatures/RobustMatcher.cpp 2 additions, 2 deletionsisis/src/control/apps/findfeatures/RobustMatcher.cpp
- isis/src/control/apps/findfeatures/assets/EW0211981114G_EW0242463603G.net.png 0 additions, 0 deletions...s/findfeatures/assets/EW0211981114G_EW0242463603G.net.png
- isis/src/control/apps/findfeatures/assets/EW0211981114G_EW0242463603G_findfeatures_small.png 0 additions, 0 deletions...assets/EW0211981114G_EW0242463603G_findfeatures_small.png
- isis/src/control/apps/findfeatures/assets/messenger_control_mosaic_comparison.jpg 0 additions, 0 deletions...ndfeatures/assets/messenger_control_mosaic_comparison.jpg
- isis/src/control/apps/findfeatures/assets/messenger_mdis_qmos.png 0 additions, 0 deletions.../control/apps/findfeatures/assets/messenger_mdis_qmos.png
- isis/src/control/apps/findfeatures/assets/messenger_qnet_control_result.jpg 0 additions, 0 deletions...pps/findfeatures/assets/messenger_qnet_control_result.jpg
- isis/src/control/apps/findfeatures/findfeatures.cpp 209 additions, 46 deletionsisis/src/control/apps/findfeatures/findfeatures.cpp
- isis/src/control/apps/findfeatures/findfeatures.xml 1814 additions, 711 deletionsisis/src/control/apps/findfeatures/findfeatures.xml
Loading
Please register or sign in to comment