Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
I
ISIS3
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
GitLab community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
aflab
astrogeology
ISIS3
Commits
c0fded36
Unverified
Commit
c0fded36
authored
6 months ago
by
Amy Stamile
Committed by
GitHub
6 months ago
Browse files
Options
Downloads
Patches
Plain Diff
kaguyatc2isis invalid BandBin values (#5692)
parent
5f857a1f
Branches
Branches containing commit
No related tags found
No related merge requests found
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
CHANGELOG.md
+1
-0
1 addition, 0 deletions
CHANGELOG.md
isis/src/kaguya/apps/kaguyatc2isis/kaguyatc2isis.cpp
+2
-2
2 additions, 2 deletions
isis/src/kaguya/apps/kaguyatc2isis/kaguyatc2isis.cpp
isis/tests/FunctionalTestsKaguyatc2isis.cpp
+4
-4
4 additions, 4 deletions
isis/tests/FunctionalTestsKaguyatc2isis.cpp
with
7 additions
and
6 deletions
CHANGELOG.md
+
1
−
0
View file @
c0fded36
...
@@ -64,6 +64,7 @@ file. Slightly modified the FunctionalTestJigsawBundleXYZ ctest accordingly. Iss
...
@@ -64,6 +64,7 @@ file. Slightly modified the FunctionalTestJigsawBundleXYZ ctest accordingly. Iss
-
Fixed PHOTOMET not accepting backplanes
[
#5281
](
https://github.com/DOI-USGS/ISIS3/issues/5281
)
-
Fixed PHOTOMET not accepting backplanes
[
#5281
](
https://github.com/DOI-USGS/ISIS3/issues/5281
)
-
Fixed dstripe parallel test failing by converting tests to gtests
[
#5613
](
https://github.com/DOI-USGS/ISIS3/issues/5613
)
-
Fixed dstripe parallel test failing by converting tests to gtests
[
#5613
](
https://github.com/DOI-USGS/ISIS3/issues/5613
)
-
Fixed autoseed SeedDomain = SampleLine only working for first overlap
[
#5673
](
https://github.com/DOI-USGS/ISIS3/issues/5673
)
-
Fixed autoseed SeedDomain = SampleLine only working for first overlap
[
#5673
](
https://github.com/DOI-USGS/ISIS3/issues/5673
)
-
Fixed kaguyatc2isis invalid BandBin values
[
#5629
](
https://github.com/DOI-USGS/ISIS3/issues/5629
)
## [8.3.0] - 2024-09-30
## [8.3.0] - 2024-09-30
...
...
This diff is collapsed.
Click to expand it.
isis/src/kaguya/apps/kaguyatc2isis/kaguyatc2isis.cpp
+
2
−
2
View file @
c0fded36
...
@@ -284,8 +284,8 @@ namespace Isis {
...
@@ -284,8 +284,8 @@ namespace Isis {
// Add the BandBin group
// Add the BandBin group
PvlGroup
bandBinGroup
(
"BandBin"
);
PvlGroup
bandBinGroup
(
"BandBin"
);
bandBinGroup
+=
PvlKeyword
(
"FilterName"
,
"BroadBand"
);
bandBinGroup
+=
PvlKeyword
(
"FilterName"
,
"BroadBand"
);
bandBinGroup
+=
PvlKeyword
(
"Center"
,
"640
nm
"
);
bandBinGroup
+=
PvlKeyword
(
"Center"
,
"640
"
,
"nanometers
"
);
bandBinGroup
+=
PvlKeyword
(
"Width"
,
"420
nm
"
);
bandBinGroup
+=
PvlKeyword
(
"Width"
,
"420
"
,
"nanometers
"
);
outcube
->
putGroup
(
bandBinGroup
);
outcube
->
putGroup
(
bandBinGroup
);
}
}
...
...
This diff is collapsed.
Click to expand it.
isis/tests/FunctionalTestsKaguyatc2isis.cpp
+
4
−
4
View file @
c0fded36
...
@@ -77,8 +77,8 @@ TEST(kaguyatc2isisTest, kaguyatc2isisTestDefault) {
...
@@ -77,8 +77,8 @@ TEST(kaguyatc2isisTest, kaguyatc2isisTestDefault) {
// Bandbin Group
// Bandbin Group
PvlGroup
&
bandbin
=
isisLabel
->
findGroup
(
"BandBin"
,
Pvl
::
Traverse
);
PvlGroup
&
bandbin
=
isisLabel
->
findGroup
(
"BandBin"
,
Pvl
::
Traverse
);
ASSERT_EQ
(
bandbin
[
"Center"
][
0
],
"640
nm
"
);
ASSERT_EQ
(
bandbin
[
"Center"
][
0
],
"640"
);
ASSERT_EQ
(
bandbin
[
"Width"
][
0
],
"420
nm
"
);
ASSERT_EQ
(
bandbin
[
"Width"
][
0
],
"420"
);
// Kernels Group
// Kernels Group
PvlGroup
&
kern
=
isisLabel
->
findGroup
(
"Kernels"
,
Pvl
::
Traverse
);
PvlGroup
&
kern
=
isisLabel
->
findGroup
(
"Kernels"
,
Pvl
::
Traverse
);
...
@@ -150,8 +150,8 @@ TEST(kaguyatc2isisTest, kaguyatc2isisTestSpSupport) {
...
@@ -150,8 +150,8 @@ TEST(kaguyatc2isisTest, kaguyatc2isisTestSpSupport) {
// Bandbin Group
// Bandbin Group
PvlGroup
&
bandbin
=
isisLabel
->
findGroup
(
"BandBin"
,
Pvl
::
Traverse
);
PvlGroup
&
bandbin
=
isisLabel
->
findGroup
(
"BandBin"
,
Pvl
::
Traverse
);
ASSERT_EQ
(
bandbin
[
"Center"
][
0
],
"640
nm
"
);
ASSERT_EQ
(
bandbin
[
"Center"
][
0
],
"640"
);
ASSERT_EQ
(
bandbin
[
"Width"
][
0
],
"420
nm
"
);
ASSERT_EQ
(
bandbin
[
"Width"
][
0
],
"420"
);
// Kernels Group
// Kernels Group
PvlGroup
&
kern
=
isisLabel
->
findGroup
(
"Kernels"
,
Pvl
::
Traverse
);
PvlGroup
&
kern
=
isisLabel
->
findGroup
(
"Kernels"
,
Pvl
::
Traverse
);
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment