Added LinkNodes management to SetNode

src/main/java/it/inaf/oats/vospace/persistence/NodeDAO.java

@@ -171,20 +171,31 @@ public class NodeDAO {
 
         String vosPath = URIUtils.returnVosPathFromNodeURI(newNode, authority);
 
-        if (recursive) {
+        boolean isLinkNode = newNode instanceof LinkNode;
+
+        // If is link ignore recursive: LinkNodes are supposed to be childless
+        if (recursive && !isLinkNode) {            
             updatePermissionsRecursively(newNode, vosPath);
         } else {
             jdbcTemplate.update(conn -> {
 
                 String sql = "UPDATE node\n"
-                        + "SET group_read = ?, group_write = ?, is_public = ?"
-                        + "WHERE node_id = id_from_vos_path(?)\n";
+                        + "SET group_read = ?, group_write = ?, is_public = ?\n";
+
+                if (isLinkNode) {
+                    sql += ", target = ?\n";
+                }
+                
+                sql += "WHERE node_id = id_from_vos_path(?)\n";
 
                 PreparedStatement ps = conn.prepareStatement(sql);
                 int i = 0;
                 ps.setArray(++i, fromPropertyToArray(ps, NodeProperties.getNodePropertyByURI(newNode, NodeProperties.GROUP_READ_URI)));
                 ps.setArray(++i, fromPropertyToArray(ps, NodeProperties.getNodePropertyByURI(newNode, NodeProperties.GROUP_WRITE_URI)));
                 ps.setBoolean(++i, Boolean.valueOf(NodeProperties.getNodePropertyByURI(newNode, NodeProperties.PUBLIC_READ_URI)));
+                if (isLinkNode) {
+                    ps.setString(++i, ((LinkNode) newNode).getTarget() );
+                }
                 ps.setString(++i, vosPath);
                 return ps;
             });
@@ -193,6 +204,22 @@ public class NodeDAO {
         return newNode;
     }
 
+    private void setLinkNodeTarget(String nodeVosPath, String target) {
+
+        jdbcTemplate.update(conn -> {
+
+            String sql = "UPDATE node\n"
+                    + "SET target = ?\n"
+                    + "WHERE node_id = id_from_vos_path(?)\n";
+
+            PreparedStatement ps = conn.prepareStatement(sql);
+            int i = 0;
+            ps.setString(++i, target);
+            ps.setString(++i, nodeVosPath);
+            return ps;
+        });
+    }
+
     private Node getNodeFromResultSet(ResultSet rs) throws SQLException {
 
         Node node = NodeUtils.getTypedNode(rs.getString("type"));

src/test/java/it/inaf/oats/vospace/persistence/NodeDAOTest.java

@@ -311,7 +311,6 @@ public class NodeDAOTest {
 
     }
 
-
     @Test
     public void testCopyNodeBranch() {
         // Let's copy /test3/m1 to /test3/group1
@@ -445,6 +444,33 @@ public class NodeDAOTest {
         assertEquals("true", NodeProperties.getNodePropertyByURI(node, NodeProperties.PUBLIC_READ_URI));
     }
 
+    @Test
+    public void testSetLinkNodeTarget() {
+
+        Property publicReadProperty = getProperty(NodeProperties.PUBLIC_READ_URI, String.valueOf(false));
+
+        LinkNode node = new LinkNode();
+        node.setUri("vos://example.com!vospace/mylink1");
+        node.getProperties().add(publicReadProperty);
+        node.setTarget("vos://example.com!vospace/mydummytarget1");
+        dao.createNode(node);
+
+        node = (LinkNode) dao.listNode("/mylink1").get();
+        assertEquals("false", NodeProperties.getNodePropertyByURI(node, NodeProperties.PUBLIC_READ_URI));
+        assertEquals("vos://example.com!vospace/mydummytarget1", node.getTarget());
+
+        node.getProperties().clear();
+        publicReadProperty.setValue(String.valueOf(true));
+        node.getProperties().add(publicReadProperty);
+        node.setTarget("vos://example.com!vospace/mydummytarget1_modded");
+
+        dao.setNode(node);
+
+        node = (LinkNode) dao.listNode("/mylink1").get();
+        assertEquals("true", NodeProperties.getNodePropertyByURI(node, NodeProperties.PUBLIC_READ_URI));
+        assertEquals("vos://example.com!vospace/mydummytarget1_modded", node.getTarget());
+    }
+
     @Test
     public void testSetNodeRecursiveGroup() {