Set 'destPathList' even on job error. This should prevent RetrieveCleaner process crash.

Signed-off-by: Cristiano Urban <cristiano.urban@inaf.it>

transfer_service/retrieve_executor.py

@@ -343,12 +343,6 @@ class RetrieveExecutor(TaskExecutor):
 
             self.jobObj.setResults(results)
             
-            if status == ("OK"):
-                self.jobObj.setPhase("COMPLETED")
-                self.jobObj.setEndTime(datetime.datetime.now().isoformat())
-                self.dbConn.insertJob(self.jobObj)
-                self.logger.info("Job phase updated to COMPLETED.")
-        
             # Add a list of physical destination paths for each VOSpace node in the node list
             self.logger.info("Generating physical destination paths for VOSpace nodes...")
             for vospacePath in self.nodeList:
@@ -361,6 +355,12 @@ class RetrieveExecutor(TaskExecutor):
                 self.destPathList.append(destPath)
             self.jobObj.jobInfo["destPathList"] = self.destPathList.copy()
 
+            if status == ("OK"):
+                self.jobObj.setPhase("COMPLETED")
+                self.jobObj.setEndTime(datetime.datetime.now().isoformat())
+                self.dbConn.insertJob(self.jobObj)
+                self.logger.info("Job phase updated to COMPLETED.")
+        
                 msg = f"""
         ########## VOSpace data retrieval procedure summary ##########