Skip to content
  1. Mar 10, 2017
  2. Mar 09, 2017
    • gmantele's avatar
      [TAP] Fix incorrect abortion handling in SYNChronous mode. · 5baff84e
      gmantele authored
      It is also now recommended to make DBConnection.executeQuery(ADQLQuery)
      return NULL if the query has been aborted (indeed, the DBConnection is
      the only one that can reliably know that fact). JDBCConnection has been
      adapted consequently.
      5baff84e
    • gmantele's avatar
      [UWS,TAP] Synchronize access to ISO8601Format. · fa206848
      gmantele authored
      This class is using static attributes of type DecimalFormat.
      Unfortunately this type of objects can NOT be accessed by multiple
      threads simultaneously: it is not thread-safe. Parsing errors,
      mostly during TAP uploads, have been experienced for this reason.
      
      To solve quickly this issue, the main static public functions of
      ISO8601Format have been synchronized.
      fa206848
    • gmantele's avatar
      Merge branch 'vforchi-master' · 8c650059
      gmantele authored
      Apply Pull Request #29 after a small adapation
      (mostly: update of the JUnit class + addition of an error message).
      8c650059
    • gmantele's avatar
      [TAP] Adapt the JUnit class testing getFile(...), · 36b4a8bf
      gmantele authored
      apply a quick space replacement (by %20) for few URIs of the configuration file
      and remove duplicated entry (encoding) from the Gradle build script.
      
      A special test has also been added in getFile(...) in order to deliver
      a clear error message for users using a former version with URIs in their
      configuration file (only for file_root_path and metadata_file).
      36b4a8bf
    • gmantele's avatar
    • gmantele's avatar
      [TAP] Fix and add JUnit tests. Now, they should work on any machine. · 0422fb7d
      gmantele authored
      Two embedded DBMS are used: H2 and a little SQLite. JDBC drivers are provided
      in the `lib` directory. The databases are created and deleted automatically
      by the JUnit tests (see `test/tap/db_testtools/DBTools for more details`).
      
      The ANT and Gradle build scripts have been updated to reflect all these test
      modifications.
      0422fb7d
  3. Mar 08, 2017
  4. Mar 03, 2017
  5. Mar 02, 2017
  6. Mar 01, 2017
  7. Feb 28, 2017
  8. Feb 24, 2017
  9. Feb 23, 2017
  10. Feb 22, 2017
  11. Feb 21, 2017
  12. Feb 20, 2017
  13. Feb 10, 2017
  14. Feb 09, 2017
  15. Feb 07, 2017
  16. Feb 01, 2017
  17. Oct 12, 2016
  18. Sep 20, 2016
    • gmantele's avatar
      [ADQL] Fix the tree generated by the parsing of NATURAL JOINs. · 7ca49f81
      gmantele authored
      The "normal" JOIN:
          A JOIN B ON A.id = B.id JOIN C ON B.id = C.id
      is correctly interpreted as:
          ( (A JOIN B ON A.id = B.id) JOIN C ON B.id = C.id )
      But with a NATURAL JOIN, the tree is mirrored:
          A NATURAL JOIN B NATURAL JOIN C
      gives:
      	( A NATURAL JOIN (B NATURAL JOIN C) )
      instead of:
          ( (A NATURAL JOIN B) NATURAL JOIN C )
      This is not a problem when the SQL translation is identical to the ADQL
      expression, but for some DBMS a conversion into a INNER JOIN ON is necessary
      and in this case we got the following SQL:
          A JOIN B JOIN C ON A.id = B.id ON B.id = C.id
      Which seems to work, but is syntactically strange.
      
      This commit should fix the generated tree. A "normal" JOIN and a NATURAL JOIN
      should now have the same form. A JUnit test has been added into TestADQLParser
      to check that: testJoinTree().
      7ca49f81